Cyberkilla

Admin

Total Posts: 5,984
Online Status: Offline
Wed Nov 12 6:00:25 EST 2008

Quote
Here's another one. On Firefox. I was fishing... got a fish. I clicked the reel in icon and waited for about 2 seconds (my FF was kind of laggy), saw that nothing happened and went with the mouse cursor over the white image on the button, then clicked again. This time, the button highlighted as if it was really pressed.

The "keep"/"drop" screen appeared, as in the screenshot below, but unfortunately the buttons were inoperable, since "An unknown error occurred: already_reeling".

I think that once you clicked on the reel in button, this event should somehow lock the button from subsequent clicks in the case when the browser or the Internet connection is slow and doesn't update the 'fish bit' GIF into the 'reeling in' one.





It does. It hides the button


Invisible War ][

Forger

Member

Total Posts: 1,013
Online Status: Offline
Wed Nov 12 8:36:52 EST 2008

Quote

It does. It hides the button


Well... apparently it hides the button in most cases, but not all.

When the page loads slowly though - that's how I caught this error, if the connection and the browser would have worked at normal params, this wouldn't have occurred - there is a chance that the reel in button will not record the event of being pressed until after it throws away that error.

That is, to say, your 'already_reeling' mutex is slightly defective (smiley)



Cyberkilla

Admin

Total Posts: 5,984
Online Status: Offline
Wed Nov 12 10:38:46 EST 2008

Quote
Quote

It does. It hides the button


Well... apparently it hides the button in most cases, but not all.

When the page loads slowly though - that's how I caught this error, if the connection and the browser would have worked at normal params, this wouldn't have occurred - there is a chance that the reel in button will not record the event of being pressed until after it throws away that error.

That is, to say, your 'already_reeling' mutex is slightly defective (smiley)


I suspect that it's simple to fix and arises almost always as a result of a weird connection delay or misclick. I will try to lock out buttons upon receiving the click event.


Invisible War ][

Forger

Member

Total Posts: 1,013
Online Status: Offline
Wed Nov 12 15:12:19 EST 2008

Quote

I suspect that it's simple to fix and arises almost always as a result of a weird connection delay or misclick. I will try to lock out buttons upon receiving the click event.


Yep, it's definitely something not easy to spot. Thanks for looking into the problem. (So I guess Internet connection ups and downs can be useful sometimes.)



Cyberkilla

Admin

Total Posts: 5,984
Online Status: Offline
Wed Nov 12 16:55:02 EST 2008

Quote
Quote

I suspect that it's simple to fix and arises almost always as a result of a weird connection delay or misclick. I will try to lock out buttons upon receiving the click event.


Yep, it's definitely something not easy to spot. Thanks for looking into the problem. (So I guess Internet connection ups and downs can be useful sometimes.)


With the state of my internet connection, I'm surprised I haven't noticed it myself.
I've only came across the problem a couple of times, a while ago.


Invisible War ][